JS rewrite

The code looked like this:
var dl = DL();

var dt_msn = DT({'class': 'top'}, 'MSN');
var dd_msn = DD(SPAN({'class': 'data'}, MSN));
AjaxEdit.changeVal(dd_msn, 'Users/setMSN', this.checkEmail, null, 'Invalid email');

var dt_jabber = DT({'class': 'top'}, 'Jabber');
var dd_jabber = DD(SPAN({'class': 'data'}, Jabber));
AjaxEdit.changeVal(dd_jabber, 'Users/setJabber', this.checkEmail, null, 'Invalid email');

ACN(dl,
    dt_msn, dd_msn,
    dt_jabber, dd_jabber
);

ACN($('service_info'), dl);

Using one of my old tips I rewrote it to:

var dl, dd_msn, dd_jabber;

ACN($('service_info'), DL(
    DT({'class': 'top'}, 'MSN'),
    dd_msn = DD(SPAN({'class': 'data'}, User.msn)),
    
    DT({'class': 'top'}, 'Jabber'),
    dd_jabber = DD(SPAN({'class': 'data'}, User.jabber))
));

AjaxEdit.changeVal(dd_msn, 'Users/setMSN', this.checkEmail, null, 'Invalid email');
AjaxEdit.changeVal(dd_jabber, 'Users/setJabber', this.checkEmail, null, 'Invalid email');

JavaScript can be beautiful.

Code · Code improvement · JavaScript · Tips 16. Aug 2007
1 comment so far

Hi Amir!

Thanks for the Orangoo Spell check. Really helpful! Keep up the good work.

Post a comment
Commenting on this post has expired.
© 2000-2009 amix. Powered by Skeletonz.